Ticket #248 (new defect)

Opened 4 months ago

rate engine drops possible best route on certain conditions

Reported by: kovzol Assigned to: areski
Priority: minor Milestone: milestone Version 1.3
Component: AGI Version: Stable 1.3.0 (Yellowjacket)
Keywords: rates tariffplans Cc:

Description

Assume that we have multiple tariffplans in a tariffgroup. Tariffplan A has the following dialprefix with this rate:

407 0.01

Tariffplan A does not have an entry about 4072.

There exists also tariffplan B with the following entry:

4072 0.02

Tariffplan B does not have an entry about 407.

Assume that somebody wants to call 4072999. Now current algorithm in the rate engine drops entry 407 (of tariffplan B) because the prefix 407 is shorter than prefix is shorter than prefix 4072 (of tariffplan A). This is should be considered a bug.

I attach a patch here for version 1.3.0. I guess more recent versions of A2B still work with the same code. I am not sure that all VoIP companies have the same problem as I have, but I can imagine that other people may use more than one tariffplan with many rates. For those people I do think this patch can help in minimizing cost and making import of rate tables easier.

Attachments

Class.RateEngine.php.patch (1.8 kB) - added by kovzol on 07/31/08 13:05:31.
patch for Class.RateEngine?.php (AGI script)

Change History

07/31/08 13:05:31 changed by kovzol

  • attachment Class.RateEngine.php.patch added.

patch for Class.RateEngine?.php (AGI script)



Google